Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update table.md #2046

Closed
wants to merge 2 commits into from
Closed

docs: Update table.md #2046

wants to merge 2 commits into from

Conversation

jkodroff
Copy link

@jkodroff jkodroff commented Sep 4, 2023

Add a link to the Snowflake docs which contain all the valid column types.

Add a link to the Snowflake docs which contain all the valid column types.
@@ -111,7 +111,7 @@ resource "snowflake_table" "table" {
Required:

- `name` (String) Column name
- `type` (String) Column type, e.g. VARIANT
- `type` (String) Column type, e.g. VARIANT. For a full list of column types, see [Summary of Data Types](https://docs.snowflake.com/en/sql-reference/intro-summary-data-types).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated, so it should not be updated directly.

You can instead add it to pkg/resources/table.go and run make docs; that will update this file.

@sfc-gh-asawicki
Copy link
Collaborator

@jkodroff, thanks for the suggestion!

I have added one comment during the review; can you correct it accordingly?

Also, please add the docs: prefix to the name of the pull request.

@jkodroff jkodroff changed the title Update table.md docs: Update table.md Oct 30, 2023
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @jkodroff 👋
As we were making bigger changes to the documentation we added your suggestion as part of the #2931 pr. We couldn't merge this, because you changed the generated markdown which would be overridden in the next change.
Nevertheless, Thank You for your contribution, we really appreciate it!

@jkodroff jkodroff deleted the patch-1 branch July 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants